Improve compute shader validation error message #3139
Merged
+5
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
cargo clippy
.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown
if applicable.Connections
Potential improvement for #2985
Description
The previous error message was easily misunderstood, as it didn't say explicitly that each dimension and the total number must be below the bounds.
For example, instead of:
after applying this PR the error is:
Thanks to @mwalczyk for the original improvement idea 🙏
Testing
In
shader.wgsl
of thehello-compute
example, I've changed the@workgroup_size(1)
to@workgroup_size(8, 8, 8)